Re: [PATCH] ALSA: usb-audio: Fix double-free in snd_usb_add_audio_stream()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, 31 Mar 2016 18:05:43 +0200,
Vladis Dronov wrote:
> 
> From: Vladis Dronov <vdronov@xxxxxxxxxx>
> Subject: [PATCH] ALSA: usb-audio: Fix double-free in error paths after snd_usb_add_audio_stream() call
> 
> create_fixed_stream_quirk(), snd_usb_parse_audio_interface() and
> create_uaxx_quirk() functions allocate the audioformat object by themselves
> and free it upon error before returning. However, once the object is linked
> to a stream, it's freed again in snd_usb_audio_pcm_free(), thus it'll be
> double-freed, eventually resulting in a memory corruption.
> 
> This patch fixes these failures in the error paths by unlinking the audioformat
> object before freeing it.
> 
> Based on a patch by Takashi Iwai" <tiwai@xxxxxxx>
> 
> [Note for stable backports:
>  this patch requires the commit 902eb7fd1e4a ('ALSA: usb-audio: Minor
>  code cleanup in create_fixed_stream_quirk()')]
> 
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1283358
> Reported-by: Ralf Spenneberg <ralf@xxxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # see the note above
> Signed-off-by: Vladis Dronov <vdronov@xxxxxxxxxx>

Applied, thanks.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux