Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

[Bo Shen <voice.shen@xxxxxxxxx>]

Hi Mark,

On 01/15/2015 07:54 PM, Mark Brown wrote:
> On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote:
>
> > +#ifdef CONFIG_OF
> > +static enum wm8904_type wm8904_data = WM8904;
> > +static enum wm8904_type wm8912_data = WM8912;
> > +
> > +static const struct of_device_id wm8904_of_match[] = {
> > +	{
> > +		.compatible = "wlf,wm8904",
> > +		.data = &wm8904_data,
>
> Does this end up in the i2c_driver_id driver data or do we need some
> extra code when devtype is assigned to check for an of_node and look at
> the DT data instead?  That certainly used to be the case...

At the beginning I think as the same as you, and also add the code to 
get the data as I do in <drivers/misc/atmel-ssc.c>. However, as I 
remember, I2C seems only use the compatible string after the comma, that 
means only for "wlf,wm8904", it uses "wm8904" to match. So, I remove all 
the code I added, and just keep these, and it can get the device type 
correctly.

So, when I submit the patch and keep the code as simple as possible.

Thanks.

Best Regards,
Bo Shen

--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html