Re: [alsa-devel] [RFC v2 PATCH] ASoC: wm8904: add CCF support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Hi Mark,

On 03/25/2014 07:27 PM, Mark Brown wrote:
On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:

  	case SND_SOC_BIAS_ON:
+			if (wm8904->mclk)
+				clk_prepare_enable(wm8904->mclk);

No, this shouldn't depend on COMMON_CLK - there is no reason other clock
API implementations shouldn't be able to use this.  Providing a clock is
something you can only do with COMMON_CLK but using one doesn't need
that, generally using a clock is done unconditionally.

Actually in probe function, it does this check, if not CCF support, the wm8904->mclk is NULL. So, we can remove the CCF check here.


Best Regards,
Bo Shen
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux