On Tue, Jan 14, 2014 at 11:25:55AM +0800, Bo Shen wrote: > Make it available to choose the clock from TK pin or RK pin. This > is hardware design decided. > --- a/sound/soc/atmel/atmel_wm8904.c > +++ b/sound/soc/atmel/atmel_wm8904.c > @@ -108,6 +108,7 @@ static int atmel_asoc_wm8904_dt_init(struct platform_device *pdev) > struct device_node *codec_np, *cpu_np; > struct snd_soc_card *card = &atmel_asoc_wm8904_card; > struct snd_soc_dai_link *dailink = &atmel_asoc_wm8904_dailink; > + struct atmel_ssc_info *ssc_info; > int ret; > > if (!np) { > @@ -115,6 +116,15 @@ static int atmel_asoc_wm8904_dt_init(struct platform_device *pdev) > return -EINVAL; > } > > + ssc_info = devm_kzalloc(&pdev->dev, sizeof(*ssc_info), GFP_KERNEL); > + if (!ssc_info) > + return -ENOMEM; > + > + ssc_info->clk_from_rk_pin = > + of_property_read_bool(np, "clk_from_rk_pin"); > + > + card->drvdata = (void *)ssc_info; Shouldn't this code be in the DAI driver? Otherwise this series looks fine to me, though the DT folks might have something to say I guess.
Attachment:
signature.asc
Description: Digital signature
- Follow-Ups:
- References:
- Prev by Date: [PATCH 0/3] ASoC: atmel_ssc_dai: add option to choose clock
- Next by Date: Re: [PATCH 3/3] Binding: atmel-wm8904: add option to choose clock
- Previous by thread: [PATCH 2/3] ASoC: atmel_wm8904: make it available to choose clock
- Next by thread: Re: [PATCH 2/3] ASoC: atmel_wm8904: make it available to choose clock
- Index(es):