Re: [alsa-devel] [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi Lars,

On 7/3/2013 09:20, Bo Shen wrote:
Hi Lars-Peter,

On 7/2/2013 23:25, Lars-Peter Clausen wrote:
On 07/02/2013 11:04 AM, Bo Shen wrote:
[...]
+    dma_params->substream = substream;

Unrelated to this patch, but having a substream field in the
dma_params seems
to be redundant, since you need to know the substream to get the
dma_params in
the first place. Looking at the code it also seems to be unused other
than this
assignment. Maybe you can send a follow up patch to remove it.

[...]


Yes, this is redundant. I will remove it in next version patches.

Sorry for mistake, this substream parameter need by the interrupt for PDC transfer, so, I will keep it.

Best Regards,
Bo Shen

--
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux