Re: [PATCH 2/3] sound/pci ioremap/iounmap balancing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




On Wed, 01 Aug 2007 06:38:16 -0400 Takashi Iwai <tiwai@xxxxxxx> 
wrote:
>This would be rater a lacking check of returned errors.
>
>The other changes look incorrect.  All these drivers use
>card->private_free callback to release the resources even for the
>error exit.  Thus, you don't need iounmap in each place.
>
>
>thanks,
>
>Takashi


Missed the callback on the audit, will repost this patch 
(sound/pci) with just the unchecked returns...

---------------------------------------
Scott Thompson / postfail@xxxxxxxxxxxx
---------------------------------------

--
Click here for a free search to find a personal injury lawyer in your area.
http://tagline.hushmail.com/fc/Ioyw6h4fOfoaL5grSba8qnlenBibb9zjK5zUaQHZiVV0JZfJFmwnj3/

-
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux