On Fri, Sep 25, 2020 at 10:40:34AM +0200, Andrea Bolognani wrote: > On Fri, 2020-09-25 at 16:21 +0800, Wei Wang wrote: > > On Fri, Sep 25, 2020 at 3:56 PM Andrea Bolognani <abologna@xxxxxxxxxx> wrote: > > > On Fri, 2020-09-25 at 10:33 +0800, Wei Wang wrote: > > > > In file included from ../src/util/virfile.c:42: > > > > /usr/include/libutil.h:43:10: fatal error: sys/_types.h: No such file or directory > > > > 43 | #include <sys/_types.h> > > > > | ^~~~~~~~~~~~~~ > > > > compilation terminated. > > > > [51/908] Compiling C object src/qemu/libvirt_driver_qemu_impl.a.p/qemu_driver.c.o > > > > ninja: build stopped: subcommand failed > > > > > > > > I have /usr/include/sys/types.h, but no "_types.h" > > > > > > Are you building on FreeBSD? Because that's where we expect > > > <libutil.h> to be included. If you're not on FreeBSD, can you check > > > which package /usr/include/libutil.h belongs to? > > > > No, I'm building on Linux. It belongs to libutil-freebsd-dev, not sure why that's needed in my build. > > Can you retry after uninstalling that package? It looks like it > messes up our header detection, and I sort of doubt we care enough > about this scenario to change our build system to cope with it. Yes, we do need to fix our build system. The user can have valid reasons for having such a package installed, and we shouldn't require them to remove it. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|