On 12/02/2013 02:28 PM, Mauricio Tavares wrote:
> [root@vmhost vms]# virsh detach-disk puppet vdb
> error: No found disk whose source path or target is vdb
>
> [root@vmhost vms]# virsh --version
> 0.10.2
> [root@vmhost vms]#
>
> This probably was solved already but if not, "No found disk" probably
> sounds better if it was "No disk found"
Sure. I'm pushing this under the trivial rule:
From aaa7484097333c8194ee6323f5a479e8121cc18c Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake@xxxxxxxxxx>
Date: Mon, 2 Dec 2013 14:40:15 -0700
Subject: [PATCH] virsh: improve grammar in error message
Based on a suggestion from Mauricio Tavares.
* tools/virsh-domain.c (cmdDetachInterface, vshFindDisk): Improve
wording.
Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
---
tools/virsh-domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1fe138c..8b80e1e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -9802,7 +9802,7 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd)
obj = xmlXPathEval(BAD_CAST buf, ctxt);
if (obj == NULL || obj->type != XPATH_NODESET ||
obj->nodesetval == NULL || obj->nodesetval->nodeNr == 0) {
- vshError(ctl, _("No found interface whose type is %s"), type);
+ vshError(ctl, _("No interface found whose type is %s"), type);
goto cleanup;
}
@@ -9960,7 +9960,7 @@ vshFindDisk(const char *doc,
}
}
- vshError(NULL, _("No found disk whose source path or target is
%s"), path);
+ vshError(NULL, _("No disk found whose source path or target is
%s"), path);
cleanup:
xmlXPathFreeObject(obj);
--
1.8.3.1
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ libvirt-users mailing list libvirt-users@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvirt-users
