Re: [PATCH] check for cfg->spiceTLS earlier in qemuProcessSPICEAllocatePorts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/2014 03:09 AM, Ján Tomko wrote:
> This saves a few lines of code and catches the error when:
> <spice autoport ='yes' defaultMode='any' ..>
>   <channel name='main' mode='secure'/>
> </spice>
> is specified with spice_tls = 0 in qemu.conf.
> 
> Instead of this error in qemuBuildGraphicsSPICECommandLine:
> error: unsupported configuration: spice secure channels set in XML
> configuration, but TLS port is not provided
> 
> an error is reported in qemuProcessSPICEAllocatePorts:
> error: unsupported configuration: Auto allocation of spice TLS port
> requested but spice TLS is disabled in qemu.conf
> 
> Inspired by:
> https://www.redhat.com/archives/libvir-list/2014-June/msg01408.html
> ---
>  src/qemu/qemu_process.c | 33 +++++++++++----------------------
>  1 file changed, 11 insertions(+), 22 deletions(-)

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]