On 07/08/2014 03:52 PM, Jim Fehlig wrote: > During migration, the libxl driver starts a modify job in the > begin phase, ending the job in the confirm phase. This is > essentially VIR_MIGRATE_CHANGE_PROTECTION semantics, but the > driver does not support that flag. Without CHANGE_PROTECTION > support, the job would never be terminated in error conditions > where migrate confirm phase is not executed. Further attempts > to modify the domain would result in failure to acquire a job > after LIBXL_JOB_WAIT_TIME. > > Similar to the qemu driver, end the job in the begin phase. > Protecting the domain object across all phases of migration can > be done in a future patch adding CHANGE_PROTECTION support. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > src/libxl/libxl_driver.c | 5 +---- > src/libxl/libxl_migration.c | 16 ++++------------ > 2 files changed, 5 insertions(+), 16 deletions(-) ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list