Re: [PATCH 4/6] audit: disk: Refactor disk auditing to avoid auditing remote storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/03/14 15:30, Ján Tomko wrote:
> On 07/03/2014 12:05 PM, Peter Krempa wrote:
>> Pass the virStorageSource struct to the auditing function and check if
>> storage is local before auditting.
> 
> *auditing
> 
> This would be nice to document in auditlog.html

Well the auditlog doc states that we audit only *host resources*, thus
auditing (sometimes) incomplete info about a remote storage volume is
technically a bug.

> 
>> ---
>>  src/conf/domain_audit.c | 25 ++++++++++++++++---------
>>  src/conf/domain_audit.h |  4 ++--
>>  src/lxc/lxc_driver.c    |  6 +++---
>>  src/qemu/qemu_driver.c  |  4 ++--
>>  src/qemu/qemu_hotplug.c | 21 ++++++++-------------
>>  5 files changed, 31 insertions(+), 29 deletions(-)
>>
> 
> ACK
> 

Thanks, I'll push this one shortly.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]