On Fri, Jul 04, 2014 at 10:52:18AM +0200, Michal Privoznik wrote:
With the new wireshark installed I've noticed couple of build breaks. This fixes the problems I've seen. Michal Privoznik (2): wireshark: Include more of libvirt internals wireshark: Honor API change coming with 1.12 release tools/wireshark/src/Makefile.am | 2 +- tools/wireshark/src/packet-libvirt.c | 35 +++++++++++++++++++++++++++++++-- tools/wireshark/src/packet-libvirt.h | 18 ++--------------- tools/wireshark/util/make-dissector-reg | 7 +++++++ 4 files changed, 43 insertions(+), 19 deletions(-) -- 1.8.5.5
We could probably create a new file where we would deal with the differences just to keep the code clean. We also proabbly don't build with any other wireshark versions (I only ever built with 1.10 and 1.12), so that is something someone might try inspecting. However this is enough and working, so it's better than nothing right now, so ACK series if you fix the include in 1/2. Let's hope this won't end up looking like the vbox driver ;) Martin
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list