On 06/24/2014 01:10 AM, Peter Krempa wrote: > On 06/24/14 01:30, Eric Blake wrote: >> We are about to turn on support for active block commit. Although >> qemu 2.0 was the first version to mostly support it, that version >> mis-handles 0-length files, and doesn't have anything available for >> easy probing. But qemu 2.1 fixed bugs, and made life simpler by >> letting the 'top' argument be optional. Unless someone begs for >> active commit with qemu 2.0, for now we are just going to enable >> it only by probing for qemu 2.1 behavior (anyone backporting active >> commit can also backport the optional argument behavior). >> >> * src/qemu/qemu_monitor.h (qemuMonitorSupportsActiveCommit): New >> prototype. >> * src/qemu/qemu_monitor.c (qemuMonitorSupportsActiveCommit): >> Implement it. >> * src/qemu/qemu_monitor_json.h (qemuMonitorJSONBlockCommit): >> Allow NULL for top and base, for probing purposes. >> * src/qemu/qemu_monitor_json.c (qemuMonitorJSONBlockCommit): >> Likewise, implementing the probe. >> * tests/qemumonitorjsontest.c (mymain): Enable... >> (testQemuMonitorJSONqemuMonitorSupportsActiveCommit): ...a new test. >> > > ACK, Now pushed, after amending the commit message to point to the qemu.git commit this was gated on. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list