Re: [PATCH 5/6] audit: Add auditing for serial/parallel/channel/console characted devs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/03/2014 12:05 PM, Peter Krempa wrote:
> Add startup auditing and also hotplug auditing for said devices
> ---
>  src/conf/domain_audit.c  | 35 +++++++++++++++++++++++++++++++++++
>  src/conf/domain_audit.h  |  7 +++++++
>  src/libvirt_private.syms |  1 +
>  src/qemu/qemu_hotplug.c  | 17 +++++++++++------
>  4 files changed, 54 insertions(+), 6 deletions(-)

Missing changes in docs/auditlog.html.in

> diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
> index c4dcfa5..b7f8123 100644
> --- a/src/conf/domain_audit.c
> +++ b/src/conf/domain_audit.c

>  virDomainAuditDisk(virDomainObjPtr vm,
>                     virStorageSourcePtr oldDef,
>                     virStorageSourcePtr newDef,
> @@ -772,6 +795,18 @@ virDomainAuditStart(virDomainObjPtr vm, const char *reason, bool success)
>          virDomainAuditRedirdev(vm, redirdev, "start", true);
>      }
> 
> +    for (i = 0; i < vm->def->nserials; i++)
> +        virDomainAuditChardev(vm, NULL, vm->def->serials[i], "start", true);
> +
> +    for (i = 0; i < vm->def->nparallels; i++)
> +        virDomainAuditChardev(vm, NULL, vm->def->parallels[i], "start", true);
> +
> +    for (i = 0; i < vm->def->nchannels; i++)
> +        virDomainAuditChardev(vm, NULL, vm->def->channels[i], "start", true);
> +
> +    for (i = 0; i < vm->def->nconsoles; i++)
> +        virDomainAuditChardev(vm, NULL, vm->def->consoles[i], "start", true);
> +

I wonder if working around the first console aliased to the first serial port
(or was it the other way around?) is worth it to prevent logging the same
device twice.

ACK with the docs added.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]