On 06/28/2014 04:39 AM, Mike Perez wrote: > On Thu, Jun 5, 2014 at 6:57 AM, Ján Tomko <jtomko@xxxxxxxxxx> wrote: >> On 05/23/2014 12:06 AM, Eric Blake wrote: >>> On 05/22/2014 12:22 PM, Mike Perez wrote: >>>> This introduces two new attributes "cmd_per_lun" and "max_sectors" same >>>> with the names QEMU uses for virtio-scsi. An example of the XML: >>>> >>>> <controller type='scsi' index='0' model='virtio-scsi' cmd_per_lun='50' >>>> max_sectors='512'/> >>> >>> I'm not a fan of underscore (why type the shift key, when a dash will >>> do). The libvirt xml name does not have to exactly match the qemu >>> option name, so maybe there's some room for bikeshedding what names we >>> should actually present to the user. >>> >> >> IMO using underscores here would be consistent with other disk-related options >> like read_iops_sec; dashes are mostly used for network-related options. >> >> We could also use camelCase [1], or just roll a dice. > > Well underscores are originally what I had in my first patch [1]. Eric > what do you think? > > [1] - http://www.redhat.com/archives/libvir-list/2014-May/msg00798.html > I have pushed the underscore version (with tabs and release numbers fixed) now that we're out of the freeze. Sorry it took so long. Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list