Re: [PATCH for 1.2.6] securityselinuxlabeltest: Don't create dummy file in the srcdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/01/2014 02:58 PM, Michal Privoznik wrote:
> At the very beginning of the test we check if the underlying
> filesystem supports extended attributes as they are used to store fake
> SELinux labels. In order to check that, a dummy file is created and
> semi-random attribute is set. However, the file is created under:
> 
>   abs_srcdir "/securityselinuxlabeldata/testxattr"
> 
> which has two problems: abs_srcdir is not required to be writable, so
> it should have been abs_builddir. The second one is - there's no
> "securityselinuxlabeldata" folder under abs_builddir. The problem was
> introduced in caf164f1.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  tests/securityselinuxlabeltest.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

ACK

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]