Re: [PATCH] block/sheepdog: rename management program from collie to dog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric, Daniel, thanks for your reply and sorry for my late reply.

On Tue, Jun 24, 2014 at 1:43 AM, Eric Blake <eblake@xxxxxxxxxx> wrote:
> On 06/23/2014 12:20 AM, Hitoshi Mitake wrote:
>> The management program of latest sheepdog is named as "dog", "collie"
>> is obsolete. This patch updates the name in the configure script and
>> the sheepdog driver.
>>
>> Signed-off-by: Vasiliy Tolstov <v.tolstov@xxxxxxxxx>
>> Signed-off-by: Hitoshi Mitake <mitake.hitoshi@xxxxxxxxxxxxx>
>> ---
>>  configure.ac                           |   10 +++++-----
>>  src/storage/storage_backend_sheepdog.c |   12 ++++++------
>>  2 files changed, 11 insertions(+), 11 deletions(-)
>
> Please re-read the comments given at the first attempt at this patch:
> https://www.redhat.com/archives/libvir-list/2014-June/msg00760.html
>
>>
>> diff --git a/configure.ac b/configure.ac
>> index 710cb71..186d9e3 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1926,14 +1926,14 @@ AC_SUBST([LIBRBD_LIBS])
>>
>>  if test "$with_storage_sheepdog" = "yes" ||
>>     test "$with_storage_sheepdog" = "check"; then
>> -  AC_PATH_PROG([COLLIE], [collie], [], [$PATH:/sbin:/usr/sbin])
>> +  AC_PATH_PROG([DOG], [dog], [], [$PATH:/sbin:/usr/sbin])
>
> This is wrong; you need to test for both names, and use the correct one,
> in order to be back-compat safe.
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

I missed the point of compatibility. I'll post v2 which doesn't break it later.

Thanks,
Hitoshi

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]