Re: [PATCH] domain conf: Fix whitespace around judgement operation when parsing 'managed' attribute.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-06-25 at 12:43 -0600, Eric Blake wrote: 
> On 06/25/2014 02:45 AM, Chen Fan wrote:
> 
> Long subject line.  Please try to fit subjects in 60 characters or less
> (look at 'git shortlog -30' for a good example).
> 
> > Signed-off-by: Chen Fan <chen.fan.fnst@xxxxxxxxxxxxxx>
> > ---
> >  src/conf/domain_conf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK and pushed, after amending the commit message slightly.
> 
Thanks,
Chen

> > 
> > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> > index 02c394f..b7aa4f5 100644
> > --- a/src/conf/domain_conf.c
> > +++ b/src/conf/domain_conf.c
> > @@ -4261,7 +4261,7 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node,
> >       * element that might be (pure hostdev, or higher level device
> >       * (e.g. <interface>) with type='hostdev')
> >       */
> > -    if ((managed = virXMLPropString(node, "managed"))!= NULL) {
> > +    if ((managed = virXMLPropString(node, "managed")) != NULL) {
> >          if (STREQ(managed, "yes"))
> >              def->managed = true;
> >      }
> > 
> 


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]