Re: [PATCH 2/2] virConnectCompareCPU: Introduce FAIL_INCOMPATIBLE flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/25/2014 06:34 AM, Jiri Denemark wrote:
> The new VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE flag for
> virConnectCompareCPU can be used to get an error
> (VIR_ERR_CPU_INCOMPATIBLE) describing the incompatibility instead of the
> usual VIR_CPU_COMPARE_INCOMPATIBLE return code.
> 
> Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> ---

>   *
> - * Returns comparison result according to enum virCPUCompareResult
> + * Returns comparison result according to enum virCPUCompareResult. If
> + * VIR_CONNECT_COMPARE_CPU_FAIL_INCOMPATIBLE is used and @xmlDesc CPU is
> + * incompatible with host CPU, this function will return VIR_CPU_COMPARE_ERROR
> + * (instead of VIR_CPU_COMPARE_INCOMPATIBLE) and the error will use
> + * VIR_ERR_CPU_INCOMPATIBLE code the error message will provide more details
> + * about the incompatibility.

Reads better if you change the tail to:

the error will use the VIR_ERR_CPU_INCOMPATIBLE code with a message
providing more details about the incompatibility

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]