Re: [PATCH] Fix compiler warning while un-wraping python object to uint in libvirt_virNodeGetFreePages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/25/2014 10:18 AM, Nehal J Wani wrote:

Long subject line, and a typo.  Better is:

build: use correct int conversion in GetFreePages

then exposing the longer details in the commit body.

> Introduced by commit c8ba859bc78f5e3b0ed2590f4e8a7fa6c26ac08f
> 
> On compiling libvirt-python against libvirt 1.2.6, we get:
> 
> libvirt-override.c: In function ‘libvirt_virNodeGetFreePages’:
> libvirt-override.c:7811:9: warning: pointer targets in passing argument 2 of ‘libvirt_intUnwrap’ differ in signedness [-Wpointer-sign]
>          if (libvirt_intUnwrap(tmp, &pages[i]) < 0)
>          ^
> In file included from libvirt-override.c:24:0:
> typewrappers.h:169:5: note: expected ‘int *’ but argument is of type ‘unsigned int *’
>  int libvirt_intUnwrap(PyObject *obj, int *val);
>      ^
> ---
>  libvirt-override.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK and will push shortly.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]