On Wed, Jun 25, 2014 at 06:31:43PM +0800, Olivia Yin wrote: > Patch fd0f22ed414e114664f4140306834bedd19f52c9 discard virtio-serial > device support on PPC machine. > > Most PPC boards don't use -chardev with non-virtio serial device > except pseries which uses -device spapr-vty with -chardev. > > Signed-off-by: Olivia Yin <Hong-Hua.Yin@xxxxxxxxxxxxx> > --- > src/qemu/qemu_capabilities.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Can you provide 2 test cases for tests/qemuxml2argvtest for this - one to test pseries required config and one to test non-pseries configs - so we can ensure we don't have a regression again. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list