Re: [PATCH v4] Only set SELinux seclabel if supported by the host.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 18, 2014 at 01:22:12PM +0200, Cedric Bosdonnat wrote:
> On Wed, 2014-06-18 at 11:11 +0200, Christophe Fergeau wrote:
> > > +static gboolean gvir_sandbox_builder_construct_security(GVirSandboxBuilder *builder,
> > > +                                                        GVirSandboxConfig *config,
> > > +                                                        const gchar *statedir G_GNUC_UNUSED,
> > > +                                                        GVirConfigDomain *domain,
> > > +                                                        GError **error)
> > > +{
> > > +    GVirConnection *connection = gvir_sandbox_builder_get_connection(builder);
> > > +    GVirConfigCapabilities *configCapabilities;
> > > +    GVirConfigCapabilitiesHost *hostCapabilities;
> > > +    GList *secmodels, *iter;
> > > +    gboolean supportsSelinux = FALSE;
> > > +
> > > +    /* What security models are available on the host? */
> > > +    if (!(configCapabilities = gvir_connection_get_capabilities(connection, error))) {
> > 
> > Missing g_object_unref(connection); here too.
> 
> Oops, I forgot that one case indeed.

I've pushed this patch with this missing _unref squashed in.

Christophe

Attachment: pgpBM1cxjyPZd.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]