Re: [PATCHv5 14/19] qemu: monitor: Add argument for specifying backing name for block commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/19/2014 07:59 AM, Peter Krempa wrote:
> To allow changing the name that is recorded in the overlay of the TOP
> image used in a block commit operation, we need to specify the backing
> name to qemu. This is done via the "backing-file" attribute to the
> block-commit command.

Yeah, I can see how this one conflicts with my work on active commit.
This one is also gated by waiting for qemu.git to have Jeff's work added.

> ---
>  src/qemu/qemu_capabilities.c | 2 +-
>  src/qemu/qemu_driver.c       | 1 +
>  src/qemu/qemu_monitor.c      | 8 +++++---
>  src/qemu/qemu_monitor.h      | 1 +
>  src/qemu/qemu_monitor_json.c | 2 ++
>  src/qemu/qemu_monitor_json.h | 1 +
>  tests/qemumonitorjsontest.c  | 6 +++---
>  7 files changed, 14 insertions(+), 7 deletions(-)
> 

This one just adds the parameter placeholder, but never supplies it, so
it is safe.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]