On 06/19/2014 07:59 AM, Peter Krempa wrote:
> Due to various refactors and compatibility with the virstoragetest the
> relPath field of the virStorageSource structure was always filled either
> with the relative name or the full path in case of abslutely backed
s/abslutely/absolutely/
> storage. Return it's original purpose to store only the relative name of
s/it's/its/
> the disk if it is backed relatively and tweak the tests.
> ---
> src/storage/storage_driver.c | 4 ----
> src/util/virstoragefile.c | 21 +++++++++------------
> src/util/virstoragefile.h | 4 ++--
> tests/virstoragetest.c | 25 +++----------------------
> 4 files changed, 14 insertions(+), 40 deletions(-)
>
> +++ b/src/util/virstoragefile.h
> @@ -247,8 +247,8 @@ struct _virStorageSource {
> virStorageDriverDataPtr drv;
>
> /* metadata about storage image which need separate fields */
> - /* Name of the current file as spelled by the user (top level) or
> - * metadata of the overlay (if this is a backing store). */
> + /* Relative path of the backing image from the parent NULL if
s/parent/parent,/
> + * backed by absolute path */
My confusion in 4/19 was based on misinterpreting the purpose of this
field. May I suggest:
/* Relative name by which this image was opened from its parent, or NULL
if this image was opened by absolute name */
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list