Re: [PATCH 0/4] Couple of nodeinfo enhancements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/20/2014 05:55 AM, Michal Privoznik wrote:
> On 20.06.2014 13:40, Ján Tomko wrote:

>> Fails syntax-check for me:
>> tests/nodeinfodata/linux-armv6l-raspberrypi.cpuinfo:3:Features       
>> : swp
>> half thumb fastmult vfp edsp java tls
>> maint.mk: found trailing blank(s)
> 
> I'm undecided how to fix this. The cpuinfo file is pure copy&paste from
> the /proc/cpuinfo on my Raspberry which does contain the trailing
> whitespace. So while I'd like to keep the cpuinfo in sync with its
> origin, it's causing the syntax-check error. So maybe add a syntax-check
> rule exception?

Yes, that's standard behavior - we want to exempt files that are
copy-and-paste from actual systems, since we want to test that our code
handles what they will actually encounter.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]