On 06/20/2014 06:59 AM, Laine Stump wrote: > Although the original patch in this thread is already ACKed, I decided > that in the interest of future expansion, I wanted to set up the > parser to more easily add recognition of other devices without needing > to re-check the string "-device", etc. Instead of checking for > "-device" and the device name in the same clause, this separates the > two so that other devices can be checked for without re-doing > STREQ(arg, "-device"). Parsing for new devices can just add another > "if STRPREFIX(opts, "blah")" clause, then do WANT_VALUE()). > > I'm planning to squash this patch into the original patch before > pushing, but didn't want to resend the whole thing, as most of it was > corrections to test data. > > --- > src/qemu/qemu_command.c | 30 ++++++++++++++++++++++++------ > 1 file changed, 24 insertions(+), 6 deletions(-) This additional squash in is definitely more extensible. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list