On 06/09/2014 04:29 AM, Laine Stump wrote:
> There are no options to parse here, and all three possible device
> names have the same prefix ("virtio-balloon" with "-ccw", "-pci", or
> "-device" appended), so it is fairly simple.
>
> qemuParseCommandLineString() previously would always add a <memballoon
> model='virtio'/> to every result (the comments erroneously say that it
> is adding a <memballoon model='none'/>) This has been changed to add
> model='none', and 84 test case xml's updated accordingly (so that
> qemuxml2argvtest won't fail).
>
> Now that the memballoon device is properly parsed, we can safely add a
> test for properly ignoring -nodefconfig and -nodefaults. Rather than
> adding an entire new test case for this (and memballoon), we just
> randomly pick the clock-utc test and modify it slightly to fulfill the
> purpose.
Wise decision - it's already big enough tweaking everything :)
> ---
>
> I don't necessarily have any love for the memory balloon driver, but
> this ended up being necessary in order to prevent test failures after
> fixing the patch here to not ignore unrecognized -device args:
>
> https://www.redhat.com/archives/libvir-list/2014-June/msg00388.html
ACK. Big patch, but only 2 or 3 files contain any real changes, and all
the rest is mechanical fallout.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list