Re: [PATCH 4/5] interface: clean up virInterfaceDefParseXML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/19/2014 04:48 AM, Laine Stump wrote:
> the switch cases for the 4 different interface types had repetitive
> code which has now been pulled out as common. While touching those
> lines, some extra usage of "!= NULL" etc has been eliminated to make
> things more compact and inline with current coding practices.
> 
> NB: parentIfType == VIR_INTERFACE_TYPE_LAST means that this is a
> toplevel interface (not a subordinate of a bridge or bond). Only
> toplevel interfaces can have a start mode, mtu, or IP address element.
> ---
>  src/conf/interface_conf.c | 68 +++++++++++++----------------------------------
>  1 file changed, 18 insertions(+), 50 deletions(-)
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]