On 06/19/2014 03:28 AM, Peter Krempa wrote: > On 06/19/14 01:22, Eric Blake wrote: >> Add knobs to virsh to manage a 2-phase active commit of the top >> layer, similar to knobs already present on blockcopy. While this >> code will fail until later patches actually implement the new >> knobs in the qemu driver, doing it now proves that the API is >> usable and also makes it easier for testing the qemu changes as >> they are made. >> >> * tools/virsh-domain.c (cmdBlockCommit): Add --active, --pivot, >> and --finish options, modeled after blockcopy. >> (blockJobImpl): Support --active flag. >> * tools/virsh.pod (blockcommit): Document new flags. >> (blockjob): Mention 2-phase commit interaction. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- >> tools/virsh-domain.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++------ >> tools/virsh.pod | 32 +++++++++++++++++++++--------- >> 2 files changed, 73 insertions(+), 15 deletions(-) >> > > This doesn't depend on anything qemu-specific and thus is safe to push > async. > > ACK. > Pushed this one. I'm holding off on the others for a bit more (to see how Jeff's qemu patches fare, and possibly rebase my patches on top of your work for copying virStorageSource) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list