Ian Campbell wrote: > On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote: > >> + if (xenXMConfigGetString(conf, "extra", &extra, NULL) < 0) >> > > This was subtly broken. The default needs to be "". > Turns out, it wasn't :). Prior to this patch, def->os.cmdline was set to NULL if 'extra' did not exist or was empty. I pushed a fix to restore the behavior, as your original patch did https://www.redhat.com/archives/libvir-list/2014-June/msg00857.html Regards, Jim -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list