On 06/17/2014 02:28 AM, Yohan BELLEGUIC wrote: > there is a segfault in the vbox driver when taking a snapshot in the > following functions: > - vboxDomainGetXMLDesc > - vboxSnapshotGetReadWriteDisks > - vboxSnapshotGetReadOnlyDisks > > The virStorageSourcePtr in virDomainDiskDef was not correctly allocated. Aha; this happened because your commits for adding vbox snapshots (commit 4dc5d8f and friends) were written before my patch that redid disk allocation (commit bc3f5f1) but applied after, and Dan didn't know to rebase across the semantic difference. > --- > src/vbox/vbox_tmpl.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) ACK and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list