On 06/16/2014 11:58 AM, Adam Litke wrote: >>> The most obvious alternative is to just introduce a new event >>> BLOCK_JOB_EVENT_2 or something less sucky. That still leaves Anyone have a suggestion for a better name? I used VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2; and about the only other name I could come up with was the longer VIR_DOMAIN_EVENT_ID_BLOCK_DEVICE_JOB, since we are pinning the disk parameter of the callback to the destination device name. >>> the question of how to generate the old event in the fact of >>> a disk with no local name - we could use empty string '' as >>> the "path" if the disk lacks one. Or we could simply not emit >>> the old style event. I'd probably go for empty string though. >> >> Adam was the one that brought this issue up in the first place. Adam, >> would you be okay registering for a new event id that guarantees you get >> a stable name? > > Yeah, this would be fine for me. Okay, v2 is posted along those lines. https://www.redhat.com/archives/libvir-list/2014-June/msg00748.html -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list