On 06/16/2014 01:36 AM, Peter Krempa wrote: > On 06/13/14 18:31, Eric Blake wrote: >> The next patch will be adding tests; for ease of review of that >> patch, I want to create common context lines that don't change >> when the new tests are added (it's easier to visually review >> additions than it is to review an entire chunk of tests rewritten >> into another larger chunk of tests). >> >> * tests/virstoragetest.c (mymain): Add a parameter and renumber >> the lookup tests. > > Not entirely clear why the new parameter is needed, but gets clarified > in the next patch. I amended the commit message to mention the purpose of the new parameter... > >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- >> tests/virstoragetest.c | 79 +++++++++++++++++++++++++------------------------- >> 1 file changed, 40 insertions(+), 39 deletions(-) >> > > ACK, and pushed the series. Thanks for the review. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list