Re: [PATCH] qemu: snapshot: Don't mark all block disks for metadata reuse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/16/14 16:00, Eric Blake wrote:
> On 06/16/2014 06:29 AM, Peter Krempa wrote:
>> For block devices used as snapshot source the new snapshot code would
>> set the reuse flag. This inhibits to take snapshot without specially
>> preparing the block image before taking the snapshot.
>>
>> Fortunately this is not a regression as only the new way of specifying
>> snapshot source is affected.
>>
>> For the followin snapshot XML:
>>  <domainsnapshot>
>>    <disks>
>>      <disk name='vda' type='block'>
>>        <driver type='qcow2'/>
>>        <source dev="/dev/andariel/testsnap" />
>>      </disk>
>>    </disks>
>>  </domainsnapshot>
>>
>> You'd get:
>> error: internal error: unable to execute QEMU command 'transaction': Image is not in qcow2 format
>>
>> After this patch the snapshot is created successfully.
>> ---
>>  src/qemu/qemu_driver.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> ACK.
> 


Pushed; Thanks.

Peter

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]