Re: [PATCH] virNetDevGetLinkInfo: Don't report link speed if NIC's down

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/13/2014 11:30 AM, Daniel P. Berrange wrote:
> On Fri, Jun 13, 2014 at 08:46:59AM +0200, Michal Privoznik wrote:
>> The kernel's more broken than one would think. Various drivers report
>> various (usually spurious) values if the interface is down. While on
>> some we experience -EINVAL when read()-ing the speed sysfs file, with
>> other drivers we might get anything from 0 to UINT_MAX. If that's the
>> case it's better to not report link speed. Well, the interface is down
>> anyway.
> Wow, that's really awful. I think that warrants a bug report against
> the kernelt too since such inconsistency can't be useful to anyone.

This list shows just the variations I found on my own system:

https://www.redhat.com/archives/libvir-list/2014-June/msg00594.html

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]