Re: [PATCH] vmware: make version parsing more robust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/09/2014 10:12 AM, Jean-Baptiste Rouault wrote:
> On Monday 28 April 2014 13:46:54 Ján Tomko wrote:
>> On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote:
>>> Since commit d69415d4, vmware version is parsed from both stdout and
>>> stderr. This patch makes version parsing work even if there is garbage
>>> (libvirt debug messages for example) in the command output.
>>
>> For libvirt's debug messages, we have virLogProbablyLogMessage that can
>> check if the message matches libvirt's format.
>>
>> Should we really ignore all garbage?
> 
> Honestly I don't know, but as of today the only garbage I saw there was from 
> libvirt. Apart from the version string, I don't think there could be useful 
> information in the command output.
> 

It's probably not worth the trouble.

ACK to your patch, I will push later today.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]