On 06/09/2014 10:38 PM, Jim Fehlig wrote: > Eric Blake wrote: >> Jim Fehlig reported a regression found by libvirt-TCK tests: >> >> Commit 2279d560 converted a boolean into a pointer with the intent of >> transferring that pointer out of a temporary object into the caller's >> data structure. The temporary structure meant that meta->encryption >> was always NULL on entry, so we could get away with blindly allocating >> the pointer when the header said so. But later commits then tweaked >> things to do backing chain detection in-place, rather than via a >> temporary object; this has the net result that meta->encryption can be >> non-NULL on entry. > > For reference, bisected and found the 'later commit' you mentioned to be > > commit 8823272d41a259c1246c05d89f40ad3614fba58c Thanks for doing that bisect. > > ACK. I've improved the commit message and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list