Re: [PATCH] vbox: fix compilation error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Eric Blake wrote:

> On 06/10/2014 11:10 AM, Roman Bogorodskiy wrote:
> > clang complains about possibly uninitialized variable:
> > 
> > vbox/vbox_snapshot_conf.c:1355:9: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> >     if (!(xPathContext = xmlXPathNewContext(xml))) {
> >         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > So init 'ret' with NULL.
> > ---
> >  src/vbox/vbox_snapshot_conf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK; you can push this sort of fix under the trivial build-breaker rule.

Pushed, thanks!

Roman Bogorodskiy

Attachment: pgpB7oUPFIlPv.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]