2014-05-11 12:08 GMT+02:00 Martin Kletzander <mkletzan@xxxxxxxxxx>: > On Sat, May 10, 2014 at 04:41:16PM +0200, Matthias Bolte wrote: >> >> The original implementation of the VMX config parser assumed that the >> virtualHW.version would have more influence on the content of the VMX >> file than it actually seems to have. It started with accepting only >> version 4. Additonal versions were added later without any additional > > > s/Additonal/Additional/ > > >> changes in the parser itself. This suggests that the influence of the >> virtualHW.version on the content and format of the VMX file is small >> or non-existent. >> >> The parser worked without any changes across several virtualHW and >> vSphere versions. So instead of adding new virtualHW.version values to >> the parser as they come along, or adding an extra flag to allow unknown >> virtualHW.version values just relax the check to require version 4 or >> later. >> --- >> >> This patch is meant as a alternative for this patch series: >> https://www.redhat.com/archives/libvir-list/2014-May/msg00122.html >> > > ACK, totally agree, I was just afraid of suggesting something like > this :-) > > Martin Thanks, pushed. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list