Re: [PATCH 0/3] Attach USB hostdevs using serial id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 05, 2014 at 08:59:41PM +0200, Ján Tomko wrote:
> Originally posted a year ago:
> https://www.redhat.com/archives/libvir-list/2013-June/msg00624.html
> 
> Rebased, with tests and nodedev 'implementation' and some nits fixed.

I'm in two minds about this idea really. I can understand the
motivation behind it, but this is a bit of a divergance from
how we identify & address devices generally. For USB I'd be
more interested in seeing us have the ability to pick devices
based on the USB port they're plugged into.

I think when you start identifying devices based on arbitrary
metadata attributes of the device like its serial number, then
this is getting into something that the external mgmt app should
do. IMHO libvirt should focus on identifying devices based on
the device addressing schemes, and providing the metadata via
the node device APIs for apps to consume.

The patch adding serial number/string to the node device driver
XML does make sense though. We should also add the USB port
number to that, since that's a stable attribute which doesn't
change across plug/unplug, unlike the device number we currently
use. And then allow the <address> element to specify the port
number too.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]