On Thu, Jun 05, 2014 at 01:03:47PM +0200, Cedric Bosdonnat wrote: > On Thu, 2014-06-05 at 10:37 +0100, Daniel P. Berrange wrote: > > On Thu, Jun 05, 2014 at 11:32:22AM +0200, Christophe Fergeau wrote: > > > Hey, > > > > > > Looks good to me. > > > There's a 'Nuernberg' typo in the copyright lines > > > I'm wondering if GVirConfigCapabilitiesSecmodel should be > > > GVirConfigCapabilitiesHostSecmodel as this is only available under the > > > host node. > > > > Yes, makes sense. > > > > > Also, libvirt uses the spelling SecModel/secmodel, might be nice to > > > follow that (or SecModel/sec_model ?) > > > > Yes, since 'secmodel' is an abbreviation for 'Security model' both > > the 'S' and 'M' should be capitalized. > > Ok, I'll fix those... is there anything else to fix in a v2? Apart from these naming things, the actual code looked good. Oh, since you ask, bonus points if you add a _get_doi() method in addition to _get_model() :) Christophe
Attachment:
pgp8FJGBSvwE9.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list