On Wed, Jun 04, 2014 at 04:56:28PM +0200, Martin Kletzander wrote: > @@ -43,9 +43,17 @@ typedef virNumaTuneDef *virNumaTuneDefPtr; > struct _virNumaTuneDef { > struct { > virBitmapPtr nodemask; > - int mode; > + int mode; /* enum virDomainNumatuneMemMode */ > int placement_mode; /* enum virNumaTuneMemPlacementMode */ > - } memory; > + } memory; /* pinning for all the memory */ > + > + struct mem_node { Declaring structs inline without typedefs isn't our usual style. There should be a typedef for virNumaTuneMemNodeDef & virNumaTuneMemNodeDefPtr Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list