Re: [PATCH] tests: Build virstoragetest only when storage driver is compiled too

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 03, 2014 at 11:56:06AM +0200, Peter Krempa wrote:
> virstoragetest now requires parts of the storage driver to be built.
> Without this change the test can't be compiled on platforms that don't
> build the storage driver (mingw).
> 
> make[2]: *** No rule to make target `../src/libvirt_driver_storage_impl.la', needed by `virstoragetest.exe'.  Stop.
> 
> Broken by commit 713cc3b0a7ff8ad42b4c13429b624d1b2b5a99f2
> ---
>  tests/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index f9f2b84..1fdfd3b 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -162,7 +162,6 @@ test_programs = virshtest sockettest \
>  	virstringtest \
>  	virportallocatortest \
>  	sysinfotest \
> -	virstoragetest \
>  	virnetdevbandwidthtest \
>  	virkmodtest \
>  	vircapstest \
> @@ -279,7 +278,8 @@ test_programs += nwfilterxml2firewalltest
>  endif WITH_NWFILTER
> 
>  if WITH_STORAGE
> -test_programs += storagevolxml2argvtest
> +test_programs += storagevolxml2argvtest \
> +	virstoragetest
>  endif WITH_STORAGE

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]