On Thu, May 15, 2014 at 10:31:05AM +0200, Ján Tomko wrote:
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index f0df1a6..7504a38 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1513,6 +1513,20 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver, virDomainObjPtr vm,
> return false;
> }
>
> + for (i = 0; i < def->cpu->nfeatures; i++) {
> + virCPUFeatureDefPtr feature = &def->cpu->features[i];
> +
> + if (feature->policy != VIR_CPU_FEATURE_REQUIRE)
> + continue;
> +
> + if (STREQ(feature->name, "invtsc")) {
> + virReportError(VIR_ERR_OPERATION_INVALID,
> + _("domain has CPU feature: %s"),
> + feature->name);
> + return false;
> + }
> + }
Could you add a comment describing why we forbid migration with
this feature set. It probably isn't obvious to some random person
reading this in the future :-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list