Laine Stump wrote: > Reported by: Roman Bogorodskiy <bogorodskiy@xxxxxxxxx> > > Some of the tests for virTimeLocalOffsetFromUTC set an imaginary > timezone that attempts to force dyalight savings time active all the > time by setting a start date of 0/00:00:00 and end date of > 366/23:59:59. Since the day is 0-based, 366 really means "day 367" > which will never occur - this was an attempt to eliminate problems > with DST not being active in some cases right around midnight on > January 1. Even though it didn't completely solve the problem, it > didn't seem to cause harm so it was left in the test timezones. > > Although Linux glibc doesn't mind having a DST end date of 366, > FreeBSD refuses to use such timezones, so the tests fail. This patch > changes the 366 to 365. > > This may or may not cause failure of the remaining DST tests around > midnight Jan 1. If so, we will need to disable those tests at year's > end too. > --- > Pushed as a build breaker. Thanks! Now 'make check' passes for me on FreeBSD. Roman Bogorodskiy
Attachment:
pgp0FppSbyhFm.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list