On 05/29/14 16:38, Eric Blake wrote: > On 05/29/2014 03:08 AM, Peter Krempa wrote: >> Currently we don't support mixed (external + internal) snapshots. The >> code detecting the snapshot type didn't make sure that the memory image >> was consistent with the snapshot type leading into strange error >> message: >> >> $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=external,file=/tmp/blah >> error: internal error: unexpected code path >> >> Fix the mixed detection code to detect this kind of mistake: >> >> $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=external,file=/tmp/blah >> error: unsupported configuration: mixing internal and external targets for a snapshot is not yet supported > > It may still be nice to support some day down the road, but a better > error message in the meantime is worth having. > >> --- >> src/qemu/qemu_driver.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > ACK; safe for 1.2.5. > Pushed; Thanks. Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list