Re: [PATCH] util: storage: Fix crash of libvirtd on network backed guest block-pull

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/29/14 16:58, Eric Blake wrote:
> On 05/29/2014 08:52 AM, Peter Krempa wrote:
>> For guests backed by gluster volumes (or other network storage) we don't
>> fill the backing chain (see qemuDomainDetermineDiskChain). This leaves
>> the "relPath" field of the top image NULL. This causes a crash in
>> virStorageFileChainLookup() when looking up a backing element for such a
>> disk.
>>
>> Since I'm working on adding support for network storage and one of the
>> steps will make the "relPath" field optional let's use STREQ_NULLABLE
>> instead of STREQ in virStorageFileChainLookup() to avoid the problem.
>> ---
>>  src/util/virstoragefile.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ACK, safe for 1.2.5.
> 

Pushed; Thanks.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]