Re: [PATCH] Explicitly pin hotplugged vcpu to all cpus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/23/14 14:37, Ján Tomko wrote:
> QEMU does not join vcpu threads after vcpu hotunplug.
> The thread might stay pinned when we hotplug the cpu again.
> 
> We were already pinning the hotplugged vcpus when a per-domain
> pinning was specified.
> 
> Explicitly pin the hotplugged vcpu to all cpus if there is no
> cpuset specified in domain XML, to make sure the vcpupin
> stays accurate.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1099836
> ---
>  src/qemu/qemu_driver.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 

The statements about qemu are true only for the downstream version.
Upstream qemu promises that it will clean up the threads once they
implement vCPU hot unplug so we will not need to execute the code you've
proposed in upstream.

NACK for merging this upstream.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]