Re: [PATCHv2 2/4] Revert "qemu: Report the offset from host UTC for RTC_CHANGE event"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/22/2014 05:07 AM, Laine Stump wrote:
> This reverts commit e31b5cf393857a6ca78d148c19393e28dfb39de1.
> 
> This commit attempted to work around a bug in the offset value
> reported by qemu's RTC_CHANGE event in the case that a variable base
> date was given on the qemu commandline. The patch mixed up the math
> involved in arriving at the corrected offset to report, and in the
> process added an unnecessary private attribute to the clock
> element. Since that element is private/internal and not used by anyone
> else, it makes sense to simplify things by removing it.
> ---
> Unchanged from V2. This is the direct result of:
> 
> git revert e31b5cf393857a6ca78d148c19393e28dfb39de1
> 
>  src/conf/domain_conf.c  | 27 ++++-----------------------
>  src/conf/domain_conf.h  |  5 -----
>  src/qemu/qemu_command.c |  3 ---
>  src/qemu/qemu_process.c | 13 -------------
>  4 files changed, 4 insertions(+), 44 deletions(-)

ACK; but don't push until we have the rest of the series in good shape.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]