Re: [PATCH] bhyve: fix virObjectUnlock() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Eric Blake wrote:

> > BTW, that's going to be a vast change, quick grep shows more than 750
> > calls of that function. 
> 
> It doesn't invalidate any existing caller to make virObjectUnlock()
> special-case NULL.  And while it DOES make any existing caller that also
> checks for NULL be a case of redundant code, we don't have to clean all
> callers up in a single patch.

Good, so I'll add a check for NULL in virObjectUnlock() and prepare a
series that cleans up the redundant if (obj) check before calling
virObjectUnlock(obj), say, on per-driver basis.

Roman Bogorodskiy

Attachment: pgpcf0QTNh7qw.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]